carverauto/serviceradar
carverauto/serviceradar
2
3
Fork 0
Code Issues 227 Pull requests 25 Projects Releases 235 Packages Wiki Activity Actions

Add identity cache ingestion correctness proposal #3300

Open
mfreeman451 wants to merge 0 commits from spec/identity-cache-ingestion-correctness into staging
pull from: spec/identity-cache-ingestion-correctness
merge into: carverauto:staging
Conversation 0 Commits - Files changed -
mfreeman451 commented 2026-05-13 20:10:40 +00:00
Owner
Copy link

Summary

  • Adds an OpenSpec proposal for auditing identity cache correctness across ingestion and mutation paths.
  • Defines expected outcomes, risks of doing the work, risks of not doing it, and a caller-audit go/no-go checkpoint.
  • Makes DeviceLookup cache use opt-in by default so ingestion/write-adjacent paths do not trust stale IP cache entries.
  • Marks active lookup call sites explicit, adds device/IP-alias lifecycle cache invalidation, and adds stale-cache regression coverage.

Validation

  • openspec validate refactor-identity-cache-ingestion-correctness --strict
  • MIX_ENV=test mix compile --warnings-as-errors
  • MIX_ENV=test mix test test/serviceradar/identity/identity_cache_test.exs
  • srql-fixtures scratch DB: MIX_ENV=test mix ecto.migrate && mix test test/serviceradar/identity/device_lookup_alias_test.exs
## Summary - Adds an OpenSpec proposal for auditing identity cache correctness across ingestion and mutation paths. - Defines expected outcomes, risks of doing the work, risks of not doing it, and a caller-audit go/no-go checkpoint. - Makes `DeviceLookup` cache use opt-in by default so ingestion/write-adjacent paths do not trust stale IP cache entries. - Marks active lookup call sites explicit, adds device/IP-alias lifecycle cache invalidation, and adds stale-cache regression coverage. ## Validation - openspec validate refactor-identity-cache-ingestion-correctness --strict - MIX_ENV=test mix compile --warnings-as-errors - MIX_ENV=test mix test test/serviceradar/identity/identity_cache_test.exs - srql-fixtures scratch DB: MIX_ENV=test mix ecto.migrate && mix test test/serviceradar/identity/device_lookup_alias_test.exs
Add identity cache ingestion correctness proposal
Some checks failed
lint / lint (push) Has been cancelled
Details
Golang Tests / test-go (push) Has been cancelled
Details
64e756f2c2
Clarify identity cache proposal tradeoffs
Some checks failed
Secret Scan / gitleaks (pull_request) Successful in 25s
Details
Golang Tests / test-go (push) Successful in 1m7s
Details
lint / lint (push) Successful in 1m23s
Details
lint / lint (pull_request) Successful in 1m20s
Details
CI / build (pull_request) Has been cancelled
Details
4660e934c2
Make identity cache opt-in for ingestion lookups
Some checks failed
Secret Scan / gitleaks (pull_request) Successful in 34s
Details
lint / lint (pull_request) Successful in 1m12s
Details
lint / lint (push) Successful in 1m13s
Details
Golang Tests / test-go (push) Successful in 1m14s
Details
CI / build (pull_request) Has been cancelled
Details
537ad70a3d
Invalidate identity cache for IP alias changes
Some checks failed
Secret Scan / gitleaks (pull_request) Successful in 35s
Details
lint / lint (pull_request) Successful in 1m3s
Details
lint / lint (push) Successful in 1m6s
Details
Golang Tests / test-go (push) Successful in 1m13s
Details
CI / build (pull_request) Failing after 27m40s
Details
34c5f37f51
Some checks failed
Secret Scan / gitleaks (pull_request) Successful in 35s
Details
lint / lint (pull_request) Successful in 1m3s
Details
lint / lint (push) Successful in 1m6s
Details
Golang Tests / test-go (push) Successful in 1m13s
Details
CI / build (pull_request) Failing after 27m40s
Details
This branch is already included in the target branch. There is nothing to merge.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin spec/identity-cache-ingestion-correctness:spec/identity-cache-ingestion-correctness
git switch spec/identity-cache-ingestion-correctness

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch staging
git merge --no-ff spec/identity-cache-ingestion-correctness
git switch spec/identity-cache-ingestion-correctness
git rebase staging
git switch staging
git merge --ff-only spec/identity-cache-ingestion-correctness
git switch spec/identity-cache-ingestion-correctness
git rebase staging
git switch staging
git merge --no-ff spec/identity-cache-ingestion-correctness
git switch staging
git merge --squash spec/identity-cache-ingestion-correctness
git switch staging
git merge --ff-only spec/identity-cache-ingestion-correctness
git switch staging
git merge spec/identity-cache-ingestion-correctness
git push origin staging
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
1week

   
2weeks

   
Failed compliance check

   
IP cameras

   
NATS
NATS JetStream

  
Possible security concern

   
Review effort 1/5

   
Review effort 2/5

   
Review effort 3/5

   
Review effort 4/5

   
Review effort 5/5

   
UI

   
aardvark

   
accessibility

   
amd64

   
api

   
arm64

   
auth

   
back-end

   
bgp

   
blog

   
bug
Something isn't working

  
build

   
checkers

   
ci-cd
continuous integration-continuous deployments

  
cleanup

   
cnpg
cloud-native postgres

  
codex

   
core
core service

  
dependencies
Pull requests that update a dependency file

  
device-management

   
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
dusk

   
ebpf

   
enhancement
New feature or request

  
eta 1d

   
eta 1hr

   
eta 3d

   
eta 3hr

   
feature

   
fieldsurvey

   
github_actions
Pull requests that update GitHub Actions code

  
go
Pull requests that update Go code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
javascript
Pull requests that update Javascript code

  
k8s

   
log-collector

   
mapper

   
mtr
multi traceroute

  
needs-triage

   
netflow

   
network-sweep

   
observability

   
oracle
Oracle Linux related issues

  
otel
opentelemetry logs, traces, metrics

  
plug-in

   
proton
timeplus proton streaming database

  
python

   
question
Further information is requested

  
reddit

   
redhat

   
research

   
rperf

   
rperf-checker

   
rust
Pull requests that update rust code

  
sdk

   
security

   
serviceradar-agent

   
serviceradar-agent-gateway

   
serviceradar-web

   
serviceradar-web-ng

   
siem

   
snmp

   
sysmon

   
topology

   
ubiquiti

   
wasm

   
wontfix
This will not be worked on

  
zen-engine
No labels
1week
2weeks
Failed compliance check
IP cameras
NATS
Possible security concern
Review effort 1/5
Review effort 2/5
Review effort 3/5
Review effort 4/5
Review effort 5/5
UI
aardvark
accessibility
amd64
api
arm64
auth
back-end
bgp
blog
bug
build
checkers
ci-cd
cleanup
cnpg
codex
core
dependencies
device-management
documentation
duplicate
dusk
ebpf
enhancement
eta 1d
eta 1hr
eta 3d
eta 3hr
feature
fieldsurvey
github_actions
go
good first issue
help wanted
invalid
javascript
k8s
log-collector
mapper
mtr
needs-triage
netflow
network-sweep
observability
oracle
otel
plug-in
proton
python
question
reddit
redhat
research
rperf
rperf-checker
rust
sdk
security
serviceradar-agent
serviceradar-agent-gateway
serviceradar-web
serviceradar-web-ng
siem
snmp
sysmon
topology
ubiquiti
wasm
wontfix
zen-engine
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carverauto/serviceradar!3300
No description provided.