ignore k8s agents in agent updater #3106

Merged

mfreeman451 merged 4 commits from refs/pull/3106/head into staging

2026-03-31 15:22:40 +00:00

mfreeman451 commented

2026-03-31 06:50:31 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #3108
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/3108
Original created: 2026-03-31T06:50:31Z
Original updated: 2026-03-31T15:22:43Z
Original head: carverauto/serviceradar:update/ignore-k8s-agent-updater
Original base: staging
Original merged: 2026-03-31T15:22:40Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

Imported from GitHub pull request. Original GitHub pull request: #3108 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/3108 Original created: 2026-03-31T06:50:31Z Original updated: 2026-03-31T15:22:43Z Original head: carverauto/serviceradar:update/ignore-k8s-agent-updater Original base: staging Original merged: 2026-03-31T15:22:40Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?

Copilot commented

2026-03-31 06:54:42 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @Copilot
Original URL: https://github.com/carverauto/serviceradar/pull/3108#discussion_r3013895750
Original created: 2026-03-31T06:54:42Z
Original path: go/pkg/agent/push_loop.go
Original line: 3066

The doc comment here no longer matches the following function: it says getAgentCapabilities but it now documents deploymentHelloLabels(). This is misleading and can trip comment-based tooling; update/move the comment so it describes the correct function(s).

Imported GitHub PR review comment. Original author: @Copilot Original URL: https://github.com/carverauto/serviceradar/pull/3108#discussion_r3013895750 Original created: 2026-03-31T06:54:42Z Original path: go/pkg/agent/push_loop.go Original line: 3066 --- The doc comment here no longer matches the following function: it says `getAgentCapabilities` but it now documents `deploymentHelloLabels()`. This is misleading and can trip comment-based tooling; update/move the comment so it describes the correct function(s).

Copilot commented

2026-03-31 06:54:43 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @Copilot
Original URL: https://github.com/carverauto/serviceradar/pull/3108#discussion_r3013895781
Original created: 2026-03-31T06:54:43Z
Original path: go/pkg/agent/push_loop.go
Original line: 3079

detectDeploymentType / isKubernetesRuntime / isDockerRuntime duplicate the existing deployment detection logic in go/pkg/edgeonboarding/deployment.go (see isKubernetes() / isDocker() around lines 72-108). Consider extracting this into a shared helper package to avoid divergence (e.g., future detection fixes need to be made in two places).

Imported GitHub PR review comment. Original author: @Copilot Original URL: https://github.com/carverauto/serviceradar/pull/3108#discussion_r3013895781 Original created: 2026-03-31T06:54:43Z Original path: go/pkg/agent/push_loop.go Original line: 3079 --- `detectDeploymentType` / `isKubernetesRuntime` / `isDockerRuntime` duplicate the existing deployment detection logic in `go/pkg/edgeonboarding/deployment.go` (see `isKubernetes()` / `isDocker()` around lines 72-108). Consider extracting this into a shared helper package to avoid divergence (e.g., future detection fixes need to be made in two places).

Copilot commented

2026-03-31 06:54:43 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @Copilot
Original URL: https://github.com/carverauto/serviceradar/pull/3108#discussion_r3013895800
Original created: 2026-03-31T06:54:43Z
Original path: elixir/web-ng/lib/serviceradar_web_ng_web/live/settings/agents_live/releases.ex
Original line: 1481

Kubernetes-managed agents are filtered out for the default (connected) cohort, but they can still be targeted via the "custom" cohort path (agent IDs are looked up and treated as compatible based only on os/arch). If Kubernetes-managed agents should always be excluded from rollouts, apply kubernetes_managed_agent?/1 filtering to the custom cohort selection/compatibility path as well (or filter preview.compatible_agent_ids before creating the rollout).

Imported GitHub PR review comment. Original author: @Copilot Original URL: https://github.com/carverauto/serviceradar/pull/3108#discussion_r3013895800 Original created: 2026-03-31T06:54:43Z Original path: elixir/web-ng/lib/serviceradar_web_ng_web/live/settings/agents_live/releases.ex Original line: 1481 --- Kubernetes-managed agents are filtered out for the default (connected) cohort, but they can still be targeted via the "custom" cohort path (agent IDs are looked up and treated as compatible based only on os/arch). If Kubernetes-managed agents should always be excluded from rollouts, apply `kubernetes_managed_agent?/1` filtering to the custom cohort selection/compatibility path as well (or filter `preview.compatible_agent_ids` before creating the rollout).