cleanup #3100

Merged

mfreeman451 merged 1 commit from refs/pull/3100/head into staging

2026-03-30 14:33:58 +00:00

mfreeman451 commented

2026-03-30 14:33:05 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #3102
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/3102
Original created: 2026-03-30T14:33:05Z
Original updated: 2026-03-30T14:38:15Z
Original head: carverauto/serviceradar:updates/cleanup-2
Original base: staging
Original merged: 2026-03-30T14:33:58Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

Imported from GitHub pull request. Original GitHub pull request: #3102 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/3102 Original created: 2026-03-30T14:33:05Z Original updated: 2026-03-30T14:38:15Z Original head: carverauto/serviceradar:updates/cleanup-2 Original base: staging Original merged: 2026-03-30T14:33:58Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?

Copilot commented

2026-03-30 14:38:14 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @Copilot
Original URL: https://github.com/carverauto/serviceradar/pull/3102#discussion_r3010253215
Original created: 2026-03-30T14:38:14Z
Original path: INSTALL.md
Original line: 13

INSTALL now instructs cp .env-sample .env before docker compose up -d, but:

.env-sample currently contains local-dev / integration-test variables (including absolute paths like /home/.../.local-dev-certs/...). That’s likely confusing for a Docker Compose quickstart and can leak machine-specific paths into user environments.
This PR deletes .env.example, while multiple docs still instruct cp .env.example .env (README-Docker.md, DOCKER_QUICKSTART.md, docs/docs/docker-setup.md, docker/README.md). Either update those references in the same PR, or keep a compatible .env.example (copy/symlink).
This PR removes ROADMAP.md, but docs/CNCF/CNCF_DAY0.md still links to it; that link should be updated or removed to avoid 404s.

Imported GitHub PR review comment. Original author: @Copilot Original URL: https://github.com/carverauto/serviceradar/pull/3102#discussion_r3010253215 Original created: 2026-03-30T14:38:14Z Original path: INSTALL.md Original line: 13 --- INSTALL now instructs `cp .env-sample .env` before `docker compose up -d`, but: - `.env-sample` currently contains local-dev / integration-test variables (including absolute paths like `/home/.../.local-dev-certs/...`). That’s likely confusing for a Docker Compose quickstart and can leak machine-specific paths into user environments. - This PR deletes `.env.example`, while multiple docs still instruct `cp .env.example .env` (README-Docker.md, DOCKER_QUICKSTART.md, docs/docs/docker-setup.md, docker/README.md). Either update those references in the same PR, or keep a compatible `.env.example` (copy/symlink). - This PR removes ROADMAP.md, but docs/CNCF/CNCF_DAY0.md still links to it; that link should be updated or removed to avoid 404s.

Copilot commented

2026-03-30 14:38:15 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @Copilot
Original URL: https://github.com/carverauto/serviceradar/pull/3102#discussion_r3010253275
Original created: 2026-03-30T14:38:15Z
Original path: AGENTS.md
Original line: 37

This section removes the web/ directory from the repo layout, but the Project Overview above still describes “a Next.js web UI”. Since web/ no longer exists, please update the overview wording to avoid implying there’s still a Next.js app in-tree (or clarify what replaced it).

Imported GitHub PR review comment. Original author: @Copilot Original URL: https://github.com/carverauto/serviceradar/pull/3102#discussion_r3010253275 Original created: 2026-03-30T14:38:15Z Original path: AGENTS.md Original line: 37 --- This section removes the `web/` directory from the repo layout, but the Project Overview above still describes “a Next.js web UI”. Since `web/` no longer exists, please update the overview wording to avoid implying there’s still a Next.js app in-tree (or clarify what replaced it).

Copilot commented

2026-03-30 14:38:15 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @Copilot
Original URL: https://github.com/carverauto/serviceradar/pull/3102#discussion_r3010253297
Original created: 2026-03-30T14:38:15Z
Original path: AGENTS.md
Original line: 52

This removes the Next.js web/ lint/build command, but other repo docs still reference cd web && ... (e.g. openspec/project.md). Please update those references (or remove them) so contributors don’t try to run commands against a non-existent directory.

Imported GitHub PR review comment. Original author: @Copilot Original URL: https://github.com/carverauto/serviceradar/pull/3102#discussion_r3010253297 Original created: 2026-03-30T14:38:15Z Original path: AGENTS.md Original line: 52 --- This removes the Next.js `web/` lint/build command, but other repo docs still reference `cd web && ...` (e.g. openspec/project.md). Please update those references (or remove them) so contributors don’t try to run commands against a non-existent directory.