carverauto/serviceradar

Fork 0

chore(metrics): remove dead serviceradar.sysmon.shadow.v1 acceptance [#3788] #3810

Merged

mfreeman451 merged 1 commit from work/3788-remove-sysmon-shadow-schema into staging

2026-06-14 03:37:28 +00:00

mfreeman451 commented

2026-06-14 00:39:32 +00:00

Owner

Summary

#3788 / #3801 tech-debt — remove the migration-era serviceradar.sysmon.shadow.v1 dual-write schema acceptance. No remaining producer emits it (verified by grep across go/elixir), so the metrics processor no longer needs the @legacy_sysmon_schema branch.

Change

Drop @legacy_sysmon_schema + its acceptance in metric_kind/2 (event_writer/processors/metrics.ex).
Remove the "keeps parsing legacy sysmon shadow envelopes during cutover" test.

Scope (genuinely-dead only)

The other shadow tech-debt is intentionally left because it's coupled to the still-active gRPC path and must follow the producer migration:

*_SHADOW_ENABLED env flags still gate the live sysmon/snmp publishers.
the no-op results_router handlers still absorb metric statuses the gateway forwards over gRPC.

Verified: mix compile clean, mix format, metrics processor tests 5/5.

Refs #3788, #3801

🤖 Generated with Claude Code

## Summary #3788 / #3801 tech-debt — remove the migration-era `serviceradar.sysmon.shadow.v1` dual-write schema acceptance. No remaining producer emits it (verified by grep across go/elixir), so the metrics processor no longer needs the `@legacy_sysmon_schema` branch. ## Change - Drop `@legacy_sysmon_schema` + its acceptance in `metric_kind/2` (`event_writer/processors/metrics.ex`). - Remove the "keeps parsing legacy sysmon shadow envelopes during cutover" test. ## Scope (genuinely-dead only) The other shadow tech-debt is **intentionally left** because it's coupled to the still-active gRPC path and must follow the producer migration: - `*_SHADOW_ENABLED` env flags still gate the live sysmon/snmp publishers. - the no-op `results_router` handlers still absorb metric statuses the gateway forwards over gRPC. Verified: `mix compile` clean, `mix format`, metrics processor tests 5/5. Refs #3788, #3801 🤖 Generated with [Claude Code](https://claude.com/claude-code)

mfreeman451 added 1 commit

2026-06-14 00:39:32 +00:00

chore(metrics): remove dead serviceradar.sysmon.shadow.v1 acceptance [#3788 ]

Secret Scan / gitleaks (pull_request) Successful in 54s

Details

Golang Tests / test-go (push) Successful in 2m27s

Details

lint / lint (pull_request) Failing after 2m59s

Details

lint / lint (push) Failing after 3m11s

Details

Elixir Quality / Elixir Quality (pull_request) Failing after 15m51s

Details

CI / build (pull_request) Successful in 35m6s

Details

b07cdbb850

The migration-era shadow dual-write schema has no remaining producers, so the
metrics processor no longer needs to accept serviceradar.sysmon.shadow.v1.
Drop the @legacy_sysmon_schema acceptance and its cutover test - genuinely
dead tech-debt. (The shadow ENABLE flags and the no-op results_router
handlers stay for now: they are coupled to the still-forwarded gRPC path and
must wait for the producer migration.)

Refs: #3788, #3801

Signed-off-by: Michael Freeman <mfreeman451@gmail.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

mfreeman451 referenced this pull request

2026-06-14 01:11:23 +00:00

Unified metric ingestion contract across agent/sysmon/snmp, native add-ons, and wasm plugins (OCSF-correct) #3788

mfreeman451 referenced this pull request

2026-06-14 01:11:31 +00:00

Unified metric ingestion contract across agent/sysmon/snmp, native add-ons, and wasm plugins (OCSF-correct) #3788

mfreeman451 commented

2026-06-14 01:50:34 +00:00

Author

Owner

Review pass: no blocking findings.

The removed schema branch only affected serviceradar.sysmon.shadow.v1; subject-based metrics.sysmon.* routing remains intact, so current sysmon metric envelopes should continue to parse while the legacy schema acceptance is dropped.

Review pass: no blocking findings. The removed schema branch only affected `serviceradar.sysmon.shadow.v1`; subject-based `metrics.sysmon.*` routing remains intact, so current sysmon metric envelopes should continue to parse while the legacy schema acceptance is dropped.

mfreeman451 reviewed

2026-06-14 02:47:48 +00:00

mfreeman451 left a comment

lgtm

mfreeman451 referenced this pull request

2026-06-14 03:29:48 +00:00

CI drift on staging (golangci-lint + mix format) blocks metric-contract PRs #3825

mfreeman451 merged commit e45d9dc823 into staging

2026-06-14 03:37:28 +00:00

mfreeman451 referenced this pull request from a commit

2026-06-14 03:37:29 +00:00

Merge pull request 'chore(metrics): remove dead serviceradar.sysmon.shadow.v1 acceptance [#3788]' (#3810) from work/3788-remove-sysmon-shadow-schema into staging