Remove legacy sysmon shadow/cutover metric tech-debt (post-JetStream migration) [#3788]

mfreeman451 commented

2026-06-13 23:30:17 +00:00

Owner

Remove legacy sysmon shadow / cutover metric tech-debt (post-JetStream migration)

Bundles the migration-era tech-debt deletions from carverauto/serviceradar#3788 (none currently tracked by a task/issue). These are safe to remove once the JetStream metric path is authoritative.

DELETE

@legacy_sysmon_schema "serviceradar.sysmon.shadow.v1" acceptance — event_writer/processors/metrics.ex:19,151.
AGENT_GATEWAY_SYSMON_METRICS_SHADOW_ENABLED / AGENT_GATEWAY_SNMP_METRICS_SHADOW_ENABLED env defaults — serviceradar_agent_gateway/config/runtime.exs:312-318 — and the helm sysmonMetricsShadowEnabled / snmpMetricsShadowEnabled aliases — helm/serviceradar/templates/agent-gateway.yaml:29-36.
Flag-gated direct insert maybe_insert_metrics + :plugin_result_direct_metrics_enabled — observability/plugin_result_ingestor.ex:52,200-206; serviceradar_core/config/config.exs:133. Keep build_status_row/insert_status — only the metric insert is debt.
No-op results_router sysmon/snmp metrics cutover handlers (handle_sysmon_metrics/handle_snmp_metrics → acknowledge_metrics_cutover) + their dispatch entries — results_router.ex:129-137,239-245,611; status_handler.ex source list.

KEEP — do NOT delete

sysmon_profiles (config table + UI + compiler) is configuration, not metric debt. The five sysmon metric hypertables (cpu/memory/disk/process/cpu_cluster_metrics) are unification candidates handled under the contract work, not this cleanup.

Before removing

Confirm no live producer still emits serviceradar.sysmon.shadow.v1 and no deployment sets plugin_result_direct_metrics_enabled=true or the *ShadowEnabled overrides. Rewrite the tests that pin the shadow schema (see #3788 tests list).

## Remove legacy sysmon shadow / cutover metric tech-debt (post-JetStream migration) Bundles the migration-era tech-debt deletions from carverauto/serviceradar#3788 (none currently tracked by a task/issue). These are safe to remove once the JetStream metric path is authoritative. ### DELETE - `@legacy_sysmon_schema "serviceradar.sysmon.shadow.v1"` acceptance — `event_writer/processors/metrics.ex:19,151`. - `AGENT_GATEWAY_SYSMON_METRICS_SHADOW_ENABLED` / `AGENT_GATEWAY_SNMP_METRICS_SHADOW_ENABLED` env defaults — `serviceradar_agent_gateway/config/runtime.exs:312-318` — and the helm `sysmonMetricsShadowEnabled` / `snmpMetricsShadowEnabled` aliases — `helm/serviceradar/templates/agent-gateway.yaml:29-36`. - Flag-gated direct insert `maybe_insert_metrics` + `:plugin_result_direct_metrics_enabled` — `observability/plugin_result_ingestor.ex:52,200-206`; `serviceradar_core/config/config.exs:133`. Keep `build_status_row`/`insert_status` — only the metric insert is debt. - No-op `results_router` sysmon/snmp metrics cutover handlers (`handle_sysmon_metrics`/`handle_snmp_metrics` → `acknowledge_metrics_cutover`) + their dispatch entries — `results_router.ex:129-137,239-245,611`; `status_handler.ex` source list. ### KEEP — do NOT delete `sysmon_profiles` (config table + UI + compiler) is configuration, not metric debt. The five sysmon **metric** hypertables (`cpu/memory/disk/process/cpu_cluster_metrics`) are unification candidates handled under the contract work, not this cleanup. ### Before removing Confirm no live producer still emits `serviceradar.sysmon.shadow.v1` and no deployment sets `plugin_result_direct_metrics_enabled=true` or the `*ShadowEnabled` overrides. Rewrite the tests that pin the shadow schema (see #3788 tests list).

mfreeman451 referenced this issue from a commit

2026-06-14 00:39:30 +00:00

chore(metrics): remove dead serviceradar.sysmon.shadow.v1 acceptance [#3788]

mfreeman451 referenced this issue

2026-06-14 00:39:32 +00:00

chore(metrics): remove dead serviceradar.sysmon.shadow.v1 acceptance [#3788] #3810

mfreeman451 referenced this issue

2026-06-14 00:48:42 +00:00

chore(observability): remove flag-gated dead plugin-metric direct insert [#3788] #3812

mfreeman451 referenced this issue from a commit

2026-06-14 00:48:43 +00:00

chore(observability): remove flag-gated dead plugin-metric direct insert [#3788]

mfreeman451 referenced this issue from a commit

2026-06-14 00:56:50 +00:00

fix(agent-gateway): stop double-forwarding sysmon/snmp metric statuses [#3788]

mfreeman451 referenced this issue

2026-06-14 00:57:14 +00:00

fix(agent-gateway): stop double-forwarding sysmon/snmp metric statuses [#3788] #3813

mfreeman451 referenced this issue from a commit

2026-06-14 01:05:44 +00:00

chore(agent-gateway): collapse sysmon/snmp metrics shadow flags to single enable [#3788]

mfreeman451 referenced this issue

2026-06-14 01:05:56 +00:00

chore(agent-gateway): collapse sysmon/snmp metrics shadow flags to single enable [#3788] #3815

mfreeman451 referenced this issue from a commit

2026-06-14 03:03:37 +00:00

chore(observability): remove flag-gated dead plugin-metric direct insert [#3788]

mfreeman451 referenced this issue from a commit

2026-06-14 03:04:18 +00:00

chore(agent-gateway): collapse sysmon/snmp metrics shadow flags to single enable [#3788]

mfreeman451 commented

2026-06-29 14:35:36 +00:00

Author

Owner

Re-assessed against current staging (the line numbers in the description are stale — intervening work, incl. the de-causal sweep #4319, moved a lot).

5 of the 6 DELETE items are already gone (confirmed absent repo-wide):

@legacy_sysmon_schema "serviceradar.sysmon.shadow.v1" acceptance — gone (no producer or consumer of the schema anywhere).
AGENT_GATEWAY_SYSMON_METRICS_SHADOW_ENABLED / AGENT_GATEWAY_SNMP_METRICS_SHADOW_ENABLED + the helm sysmonMetricsShadowEnabled / snmpMetricsShadowEnabled aliases — gone.
maybe_insert_metrics + :plugin_result_direct_metrics_enabled (plugin_result_ingestor.ex / config.exs) — gone.

The 6th item evolved rather than being deleted. results_router's handle_sysmon_metrics / handle_snmp_metrics (and handle_sweep_metrics) no longer call acknowledge_metrics_cutover; they now actively reject the legacy metric-via-gateway-status path:

defp reject_gateway_metric_status(status) do
  {:error, {:gateway_metric_status_not_core_routable, status[:source]}}
end

That reject is the correct safety end-state — removing it (and the "sysmon-metrics"/"snmp-metrics" dispatch) before #3788 eliminates the legacy metric path would let a straggler legacy status fall through to the default handler. So the remaining removal is folded into #3788 (this issue's parent — "the tail of #3788"), to land when the legacy path is gone.

Conclusion: no safe standalone deletion remains for this issue right now; it's effectively resolved except for the reject-handler removal, which is now tracked as part of #3788.

Re-assessed against current `staging` (the line numbers in the description are stale — intervening work, incl. the de-causal sweep #4319, moved a lot). **5 of the 6 DELETE items are already gone** (confirmed absent repo-wide): - `@legacy_sysmon_schema "serviceradar.sysmon.shadow.v1"` acceptance — gone (no producer or consumer of the schema anywhere). - `AGENT_GATEWAY_SYSMON_METRICS_SHADOW_ENABLED` / `AGENT_GATEWAY_SNMP_METRICS_SHADOW_ENABLED` + the helm `sysmonMetricsShadowEnabled` / `snmpMetricsShadowEnabled` aliases — gone. - `maybe_insert_metrics` + `:plugin_result_direct_metrics_enabled` (`plugin_result_ingestor.ex` / `config.exs`) — gone. **The 6th item evolved rather than being deleted.** `results_router`'s `handle_sysmon_metrics` / `handle_snmp_metrics` (and `handle_sweep_metrics`) no longer call `acknowledge_metrics_cutover`; they now actively **reject** the legacy metric-via-gateway-status path: ```elixir defp reject_gateway_metric_status(status) do {:error, {:gateway_metric_status_not_core_routable, status[:source]}} end ``` That reject is the correct safety end-state — removing it (and the `"sysmon-metrics"`/`"snmp-metrics"` dispatch) *before* #3788 eliminates the legacy metric path would let a straggler legacy status fall through to the default handler. So the remaining removal is **folded into #3788** (this issue's parent — "the tail of #3788"), to land when the legacy path is gone. **Conclusion:** no safe standalone deletion remains for this issue right now; it's effectively resolved except for the reject-handler removal, which is now tracked as part of #3788.

mfreeman451 commented

2026-06-29 14:36:52 +00:00

Author

Owner

Re-assessed against current staging (the line numbers in the description are stale — intervening work, incl. the de-causal sweep #4319, moved a lot).

5 of the 6 DELETE items are already gone (confirmed absent repo-wide):

@legacy_sysmon_schema "serviceradar.sysmon.shadow.v1" acceptance — gone (no producer or consumer of the schema anywhere).
AGENT_GATEWAY_SYSMON_METRICS_SHADOW_ENABLED / AGENT_GATEWAY_SNMP_METRICS_SHADOW_ENABLED + the helm sysmonMetricsShadowEnabled / snmpMetricsShadowEnabled aliases — gone.
maybe_insert_metrics + :plugin_result_direct_metrics_enabled (plugin_result_ingestor.ex / config.exs) — gone.

The 6th item evolved rather than being deleted. results_router's handle_sysmon_metrics / handle_snmp_metrics (and handle_sweep_metrics) no longer call acknowledge_metrics_cutover; they now actively reject the legacy metric-via-gateway-status path:

defp reject_gateway_metric_status(status) do
  {:error, {:gateway_metric_status_not_core_routable, status[:source]}}
end

That reject is the correct safety end-state — removing it (and the "sysmon-metrics"/"snmp-metrics" dispatch) before #3788 eliminates the legacy metric path would let a straggler legacy status fall through to the default handler. So the remaining removal is folded into #3788 (this issue's parent — "the tail of #3788"), to land when the legacy path is gone.

Conclusion: no safe standalone deletion remains for this issue right now; it's effectively resolved except for the reject-handler removal, which is now tracked as part of #3788.

Re-assessed against current `staging` (the line numbers in the description are stale — intervening work, incl. the de-causal sweep #4319, moved a lot). **5 of the 6 DELETE items are already gone** (confirmed absent repo-wide): - `@legacy_sysmon_schema "serviceradar.sysmon.shadow.v1"` acceptance — gone (no producer or consumer of the schema anywhere). - `AGENT_GATEWAY_SYSMON_METRICS_SHADOW_ENABLED` / `AGENT_GATEWAY_SNMP_METRICS_SHADOW_ENABLED` + the helm `sysmonMetricsShadowEnabled` / `snmpMetricsShadowEnabled` aliases — gone. - `maybe_insert_metrics` + `:plugin_result_direct_metrics_enabled` (`plugin_result_ingestor.ex` / `config.exs`) — gone. **The 6th item evolved rather than being deleted.** `results_router`'s `handle_sysmon_metrics` / `handle_snmp_metrics` (and `handle_sweep_metrics`) no longer call `acknowledge_metrics_cutover`; they now actively **reject** the legacy metric-via-gateway-status path: ```elixir defp reject_gateway_metric_status(status) do {:error, {:gateway_metric_status_not_core_routable, status[:source]}} end ``` That reject is the correct safety end-state — removing it (and the `"sysmon-metrics"`/`"snmp-metrics"` dispatch) *before* #3788 eliminates the legacy metric path would let a straggler legacy status fall through to the default handler. So the remaining removal is **folded into #3788** (this issue's parent — "the tail of #3788"), to land when the legacy path is gone. **Conclusion:** no safe standalone deletion remains for this issue right now; it's effectively resolved except for the reject-handler removal, which is now tracked as part of #3788.

mfreeman451 referenced this issue

2026-06-29 14:53:45 +00:00

Unified metric ingestion contract across agent/sysmon/snmp, native add-ons, and wasm plugins (OCSF-correct) #3788

Rows
Columns

Remove legacy sysmon shadow/cutover metric tech-debt (post-JetStream migration) [#3788] #3801

Remove legacy sysmon shadow / cutover metric tech-debt (post-JetStream migration)

DELETE

KEEP — do NOT delete

Before removing