fix: normalize SNMP trap bodies #3131

Merged
mfreeman451 merged 1 commit from 3130-bug-snmp-trap-body-normalization into staging 2026-04-06 06:31:25 +00:00
Owner

Summary

  • fix the built-in SNMP Zen rule so missing or empty bodies are derived from varbind text instead of persisting logs.snmp.processed
  • reconcile seeded snmp_severity rules when they still use the built-in template contract, while preserving user-authored overrides
  • add defensive SNMP varbind body fallback coverage in the Elixir and Go log parsers plus OpenSpec/spec updates

Testing

  • go test ./go/pkg/consumers/db-event-writer
  • cargo test --manifest-path rust/consumers/zen/Cargo.toml
  • mix test test/serviceradar/observability/zen_rule_templates_test.exs test/serviceradar/observability/zen_rule_seeder_test.exs test/serviceradar/event_writer/processors/logs_test.exs (still compiling serviceradar_core; no pass/fail result captured yet)
  • openspec validate fix-snmp-trap-body-normalization --strict

Issue

## Summary - fix the built-in SNMP Zen rule so missing or empty bodies are derived from varbind text instead of persisting `logs.snmp.processed` - reconcile seeded `snmp_severity` rules when they still use the built-in template contract, while preserving user-authored overrides - add defensive SNMP varbind body fallback coverage in the Elixir and Go log parsers plus OpenSpec/spec updates ## Testing - `go test ./go/pkg/consumers/db-event-writer` - `cargo test --manifest-path rust/consumers/zen/Cargo.toml` - `mix test test/serviceradar/observability/zen_rule_templates_test.exs test/serviceradar/observability/zen_rule_seeder_test.exs test/serviceradar/event_writer/processors/logs_test.exs` (still compiling `serviceradar_core`; no pass/fail result captured yet) - `openspec validate fix-snmp-trap-body-normalization --strict` ## Issue - Closes #3130
fix: normalize SNMP trap bodies (#3130)
Some checks failed
Golang Tests / test-go (push) Successful in 57s
lint / lint (push) Failing after 41s
Rust Tests / test-rust (rust/consumers/zen, cargo) (push) Successful in 3m26s
Rust Tests / test-rust (rust/log-collector, cargo) (push) Successful in 3m47s
Rust Tests / test-rust (//rust/rperf-server:rperf, rust/rperf-server, bazel) (push) Successful in 5m26s
Rust Tests / test-rust (rust/rperf-client, cargo) (push) Successful in 3m6s
lint / lint (pull_request) Failing after 40s
Rust Tests / test-rust (rust/trapd, cargo) (push) Successful in 3m32s
Secret Scan / gitleaks (pull_request) Successful in 18s
Rust Tests / test-rust (rust/srql, cargo) (push) Successful in 5m50s
CI / build (pull_request) Failing after 29m12s
3b55f51349
mfreeman451 deleted branch 3130-bug-snmp-trap-body-normalization 2026-04-06 06:31:26 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carverauto/serviceradar!3131
No description provided.