Build/build updates #3099

Merged
mfreeman451 merged 5 commits from refs/pull/3099/head into staging 2026-03-30 15:07:44 +00:00
mfreeman451 commented 2026-03-30 04:44:39 +00:00 (Migrated from github.com)
Owner

Imported from GitHub pull request.

Original GitHub pull request: #3101
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/3101
Original created: 2026-03-30T04:44:39Z
Original updated: 2026-03-30T15:07:46Z
Original head: carverauto/serviceradar:build/build-updates
Original base: staging
Original merged: 2026-03-30T15:07:44Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Code checklist before requesting a review

  • I have signed the DCO?
  • The build completes without errors?
  • All tests are passing when running make test?
Imported from GitHub pull request. Original GitHub pull request: #3101 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/3101 Original created: 2026-03-30T04:44:39Z Original updated: 2026-03-30T15:07:46Z Original head: carverauto/serviceradar:build/build-updates Original base: staging Original merged: 2026-03-30T15:07:44Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?
Copilot commented 2026-03-30 04:48:39 +00:00 (Migrated from github.com)
Author
Owner

Imported GitHub PR review comment.

Original author: @Copilot
Original URL: https://github.com/carverauto/serviceradar/pull/3101#discussion_r3007494732
Original created: 2026-03-30T04:48:39Z
Original path: MODULE.bazel
Original line: 209

The Fedora/RHEL GCC 11 built-ins entry adds only the .../11/include directory, but the surrounding toolchain config consistently includes both include and include-fixed for other GCC versions. Consider also adding /usr/lib/gcc/x86_64-redhat-linux/11/include-fixed to avoid missing fixed headers on RHEL-family hosts.

        "/usr/lib/gcc/x86_64-redhat-linux/11/include",
        "/usr/lib/gcc/x86_64-redhat-linux/11/include-fixed",
Imported GitHub PR review comment. Original author: @Copilot Original URL: https://github.com/carverauto/serviceradar/pull/3101#discussion_r3007494732 Original created: 2026-03-30T04:48:39Z Original path: MODULE.bazel Original line: 209 --- The Fedora/RHEL GCC 11 built-ins entry adds only the `.../11/include` directory, but the surrounding toolchain config consistently includes both `include` and `include-fixed` for other GCC versions. Consider also adding `/usr/lib/gcc/x86_64-redhat-linux/11/include-fixed` to avoid missing fixed headers on RHEL-family hosts. ```suggestion "/usr/lib/gcc/x86_64-redhat-linux/11/include", "/usr/lib/gcc/x86_64-redhat-linux/11/include-fixed", ```
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carverauto/serviceradar!3099
No description provided.